Skip to content

fix(webhook): preserve review comment associations#84

Closed
DragunovX16 wants to merge 1 commit into
entrius:testfrom
DragunovX16:fix/review-comment-association-evidence
Closed

fix(webhook): preserve review comment associations#84
DragunovX16 wants to merge 1 commit into
entrius:testfrom
DragunovX16:fix/review-comment-association-evidence

Conversation

@DragunovX16
Copy link
Copy Markdown
Contributor

Summary

Preserve GitHub author_association from inline PR review comments and include that evidence in label actor role resolution.

This adds reviewer_association to review_comments, stores it from pull_request_review_comment payloads, and lets contributor_repo_roles use inline PR review comments alongside PR authors, issue authors, submitted reviews, and issue/PR thread comments.

Related Issues

Fixes #83

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (describe below)

Testing

  • npm run format:check
  • npm run lint
  • npm run build
  • git diff --check

Checklist

  • I have read the Contributing Guide
  • Code builds without errors
  • New and existing tests pass (if applicable)
  • Documentation updated (if applicable)
  • No unnecessary dependencies added

@xiao-xiao-mao xiao-xiao-mao Bot added the bug Something isn't working label May 13, 2026
@anderdc
Copy link
Copy Markdown
Collaborator

anderdc commented May 20, 2026

Premise is correct but the realistic surface is narrow — would need a labeler whose only repo evidence is an "Add single comment" inline post, which is close to zero actors in practice. Schema migration plus an indefinite no-backfill window (GitHub doesn't surface historical author_association on webhook replay) costs more than the scoring delta this would unblock. Closing.

@anderdc anderdc closed this May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Inline PR review comments drop author_association, leaving label actor roles unresolved

2 participants